Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move retries createreadstream get resumption logic working #1492

Conversation

kevkim-codes
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

- Transform the rowsLimit parameter into an integer
- Change the hook into a before hook so that we don’t attempt to create multiple mock servers
- Create a guard so that the stream only writes if there are row keys to write
define new interfaces too
…into move-retries-from-createreadstream

# Conflicts:
#	src/table.ts
#	src/utils/table.ts
readRowsReqOpts should have an ECMAscript prefix to completely hide it from the user. Also remove a useless  Filter.parse.
@kevkim-codes kevkim-codes requested review from a team as code owners September 27, 2024 18:36
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Sep 27, 2024
@kevkim-codes kevkim-codes merged commit b43468e into googleapis:move-retries-createreadstream-get-resumption-logic-working Sep 27, 2024
21 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants